Conversation
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Closing this PR because the change belongs in the existing analytic-node-counts branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds active and inactive cluster node counts to the Prometheus registry using generic metrics with a
node_typelabel:parseable_active_nodes{node_type="ingestor"}parseable_active_nodes{node_type="querier"}parseable_inactive_nodes{node_type="ingestor"}parseable_inactive_nodes{node_type="querier"}Node status is determined using the existing liveness check.
Why
Using generic metrics avoids separate metric definitions for every node type and allows analytics to filter or group node counts by
node_type.Validation
cargo fmt --all -- --checkcargo check --lib --bin parseablecargo clippy --lib --bin parseable -- -D warnings